Skip to content

feat: add env var example to docker-compose, add agent config to image #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

obs-gh-mattcotter
Copy link
Collaborator

Description

Add env var example to docker-compose, add agent config to image.
The goal of this change is to make Docker usage more clear.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@@ -0,0 +1,13 @@
# A minimal default agent config which should be overwritten via a docker volume or environment variables.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this present in the image will avoid "file not found" issues when no alternative is provided via volume mount (ie when someone is running the image with env config only). If a volume is provided, that will be used instead of this.

@obs-gh-mattcotter obs-gh-mattcotter merged commit 7ff3a1a into main Dec 10, 2024
8 checks passed
@obs-gh-mattcotter obs-gh-mattcotter deleted the mc/docker branch December 10, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants